Fix #142, Standardize command responses #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -702,12 +718,12 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| void SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
| CFE_Status_t SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -683,17 +694,22 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| void SC_ManageAtsTable(int32 ArrayIndex) | |||
| CFE_Status_t SC_ManageAtsTable(int32 ArrayIndex) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -664,17 +670,22 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| void SC_ManageRtsTable(int32 ArrayIndex) | |||
| CFE_Status_t SC_ManageRtsTable(int32 ArrayIndex) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -702,12 +718,12 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| void SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
| CFE_Status_t SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
SC_RESET_DEB_EID,SC_DISABLE_RTS_DEB_EID,SC_ENABLE_RTS_DEB_EID&SC_CONT_CMD_DEB_EIDtoINFORMATIONtypeSC_TABLE_MANAGE_INF_EID) and required logic to theSC_ManageTableCmdandSC_ManageTablefunctions in order to return a success event when no errors were encountered during processing (either from the SC functions or passed through from cFE functions)SC_TABLE_MANAGE_INF_EIDTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Success event will be issued if no errors are encountered during processing of the
SC_MANAGE_TABLE_CCcommand.System(s) tested on
Debian GNU/Linux 12 (bookworm)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt